jjlogo

Digital Jukeboxes and Karaoke Machines
Sales: 888-352-3986

Welcome, Guest
Username: Password: Remember me

TOPIC: Cover art from FLAC file tags

Cover art from FLAC file tags 1 year 3 weeks ago #2581

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
It seems like this was working in the previous version, but for some reason JJ isn't picking up the cover art from my tagged FLAC files.

I've been spending some time getting art plugged into my library but it's not displaying in the lists or the browser frame.

I have verified the settings and they're correct.

I tried uploading a sample but the upload limits are too tiny even for a 5 second flac file with tags...
Tim
Last Edit: 1 year 3 weeks ago by TBacker.
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2582

  • JayShoe
  • JayShoe's Avatar
  • OFFLINE
  • Moderator
  • Posts: 458
  • Thank you received: 20
  • Karma: 9
TBacker,

You are right, the upload size was set to 120kb. I've made it 10 megs now. If you need to upload an even larger file, use the ticket system. We also have an FTP site setup for this type situation. I would give you the credentials via the ticket system.

What previous version are you referring to? The Flac stuff or album art stuff hasn't been touched to my knowledge for a very long time. Have you tried resetting your image cache?
Jay
Jukebox Jockey Sales and Support
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2584

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
The version just before 2011.12.30 is the one I was referring to. I remember seeing the empty CD image showing up that I had tagged on all of my files until I could get art loaded.

I have cleared the cache and made sure it's set to check the file's tags for art. I also took a peek in the ini file to insure it matched those settings.

I have it doing a full manual search for images while I'm at work.

I also have a test file attached here that I tagged. I edited the song down a bit to get it to fit in the upload limit then tagged it with the data from the full song.


File Attachment:

File Name: Tim_Backer_CoverArt_Flac.zip
File Size: 9,158 KB
Tim
Last Edit: 1 year 3 weeks ago by TBacker.
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2585

  • JayShoe
  • JayShoe's Avatar
  • OFFLINE
  • Moderator
  • Posts: 458
  • Thank you received: 20
  • Karma: 9
Hello Tim,

Thanks for the upload. All I can do is confirm that JJ does not read the album art from the file. Tag&Rename does.
Jay
Jukebox Jockey Sales and Support
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2586

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
Okay...it's good to know its not just me!

I know there are a couple of formats for tags on a flac file, one being ID3. Perhaps the art isn't in the same chunk as the parser is reading for the text metadata?

Let me know if you need further info.
Tim
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2588

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
For now I'm going to use MP3Tag to export the covers into my library folder. I assume if the jpg file name matches the audio file name that JJ will pick it up?
Tim
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2589

  • Tony
  • Tony's Avatar
  • OFFLINE
  • Moderator
  • Posts: 397
  • Thank you received: 16
  • Karma: 6
Hi Tim,

JJ has never "purposely" supported images in FLAC files, although it's possible that it inadvertantly worked at one point for FLAC files tagged with id3v2 tags because of the way the image info flows through from the tag reading process to the cover art displaying process. However, looking at it now it certainly won't work any more due to internal changes to the tag reader.

Having said that, the sample file that you sent me hasn't got an id3v2 tag, it has a Vorbis/FLAC tags, which according to the FLAC web site is the right way to go, although obviously id3v2 in FLAC is not uncommon:
flac.sourceforge.net/faq.html#general__tagging

I can't promise anything, but if I am able to fix it via the tag reader code (DLL) rather than in JJ itself then I will, otherwise it may be a little while before we can support it.
Tony
Lead Programmer
Jukebox Jockey
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2592

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
Tony,

Are you using a third party library for the tagging? I know the bass library also has some tagging functionality but it has limitations.
Tim
The administrator has disabled public write access.

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2593

  • Tony
  • Tony's Avatar
  • OFFLINE
  • Moderator
  • Posts: 397
  • Thank you received: 16
  • Karma: 6
Hi Tim,

JJ's tag reading stuff has quite a long history and has gradually morphed from open source stuff to my own stuff over the last 10 years or so. I know BASS has some tag reading capabilities but I have never investigated those as I have had my tag reading plugin system in place for some time, before I ever used BASS.

Anyway, I have just gone and added the ability to grab the image from the FLAC tag, it works with your file. I have attached it to this post (hopefully). Just rename your existing tag_FLAC.dll (in JJ's Plugins\TagPlugins folder) to anything but .dll (eg tag_FLAC.bak) and then put this one in place and hopefuly it will work OK for you).

On further investigation I think if you used id3v2.3 (most common) or id3v2.4 tags in your FLAC files then the images should in fact work.
Tony
Lead Programmer
Jukebox Jockey
Last Edit: 1 year 3 weeks ago by Tony. Reason: Removed tag reader attachment, there is an update one later in this thread.
The administrator has disabled public write access.
The following user(s) said Thank You: TBacker

Re: Cover art from FLAC file tags 1 year 3 weeks ago #2594

  • TBacker
  • TBacker's Avatar
  • OFFLINE
  • Junior Boarder
  • Posts: 25
  • Karma: 0
Tony wrote:
Anyway, I have just gone and added the ability to grab the image from the FLAC tag, it works with your file. I have attached it to this post (hopefully). Just rename your existing tag_FLAC.dll (in JJ's Plugins\TagPlugins folder) to anything but .dll (eg tag_FLAC.bak) and then put this one in place and hopefuly it will work OK for you).

Wow - customer service is A1++! That was quick...

Granted I'm doing this by remote (still at work), but I installed the new dll, removed the cover art folder path, cleared the cache, made sure read tag from file was on, then restarted. It's getting art, but every item is the same cover (an Alan Jackson cover). Almost like it's holding on to the first image it parses.

EDIT: I got home and tried a few things, but could not get this to work as intended. So, I decided to try a full library rescan. It started and immediately it slowed down to a crawl, eventually hanging with an out of memory condition. A second attempt after deleting databases resulted in it doing the same slowdown but then a pile of errors parsing individual files folloed by a hang.

Seems like it may not be seeing the end of the image data and is reading into the audio data? Either that or something isn't getting cleaned up between file parses.

I went back to the original dll and it rescanned the library fine (albeit with no covers).
Tony wrote:
On further investigation I think if you used id3v2.3 (most common) or id3v2.4 tags in your FLAC files then the images should in fact work.

Unfortunately most taggers don't provide a way for ID3v2 tagging of FLAC files. MP3Tag and Tag & Rename don't. They're avoiding a non-standards-compliant issue even though it works in practice. MP3Tag will allow ID3v1 tags to be written on the tail, but those tags are pretty much worthless and don't have any image capability.

Another help that would be fairly easy to code would be to have JJ look for images with the same filename as the audio file. "Huey Lewis & The News_Heart Of Rock & Roll.flac" could have a "Huey Lewis & The News_Heart Of Rock & Roll.jpg" and a Huey Lewis & The News_Heart Of Rock & Roll (1).jpg" in the same folder....
Tim
Last Edit: 1 year 3 weeks ago by TBacker.
The administrator has disabled public write access.
Time to create page: 0.704 seconds

jjlogo

© 2006+ Jukebox Jockey, LLC — All Rights Reserved.